Microsoft/bcquality
1
0
Fork 0
mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-05 14:46:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Deploy a shared MCP-tool permissions allowlist; detect legacy .claude/settings.json

Browse source 
Two related fixes, discovered together while debugging Wareco's duplicated
"Project" scope MCP entries:

1. New custom/setup/machine/settings.json template + a merge-safe deploy
   step in sync-bcquality-knowledge.ps1 (section 10): auto-approves the
   read-only/already-protocol-gated tool calls across the three
   CURABIS-managed MCP servers (businesscentral's 15 static tools, al's
   11 dev-loop tools, microsoft-learn's 3 docs tools) via
   ~/.claude/settings.json's permissions.allow -- merged into whatever
   already exists, never overwritten, since that file also carries a
   developer's personal settings. Tested against a real 298-entry
   settings.json: preserved every existing key/array untouched, added
   only the 14 genuinely-missing entries.

   Found and fixed two real bugs while building this: -AsHashtable
   doesn't exist in Windows PowerShell 5.1 (this script also runs via
   `powershell`, not just `pwsh`) -- switched to PSCustomObject +
   Add-Member. And Set-Content -Encoding utf8 writes a BOM in PS5.1 with
   no utf8NoBOM option -- switched to [System.IO.File]::WriteAllText
   with an explicit no-BOM UTF8Encoding, since the original file had no
   BOM and a JSON parser choking on one would have silently broken every
   developer's settings.json.

2. Wareco's committed .claude/settings.json still has the pre-migration
   Dynamic Tool Mode tool names (bc_actions_search/describe) and an
   enabledMcpjsonServers entry for al/businesscentral -- the latter is
   why the MCP servers panel shows them duplicated under "Project" scope
   next to the correct "User" scope registration. Added detection +
   confirmed-removal migration step (mirroring the existing .mcp.json
   migration's multi-developer coordination caveat) and Roemer station
   16 to catch this on other pre-migration repos (gtt-marine likely has
   the same file).
This commit is contained in:
Michael Dieringer 2026-08-04 07:31:46 +02:00
parent c58c3f6e0f
commit a3b79eedc2
4 changed files with 141 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
custom/agents/roemer.agent.md
View file

@ -1,7 +1,7 @@
---
kind: action-skill
id: curabis-standards-inspector
version: 7
version: 8
title: Rømer — Standards Inspector
description: >
Owns the uniformity inspection across CURABIS repos: walks one full
@ -140,6 +140,15 @@ Walk ALL stations, every time. A partial round creates false confidence
mistake. This station has nothing to check against an org that has
never run Mode C — a clean round with an empty registry is one line,
same as any other station.
16. **Legacy repo-committed `.claude/settings.json`** (2026-08-03). Grep
`.claude/settings.json` for the old Dynamic Tool Mode tool names
(`bc_actions_search`, `bc_actions_describe`, `bc_actions_invoke`) or an
`enabledMcpjsonServers` entry for `al`/`businesscentral` — same
multi-developer coordination caveat as the `.mcp.json` migration
(station covers detection only; removal needs explicit developer
confirmation via curabis-standard.agent.md's Mode B step 5). Found live
in the `Wareco` repo: causes MCP servers to show duplicated under
"Project" scope in the panel alongside the correct "User" scope entry.
CURABIS-ROEMER-001 Measure against the written standard only. Every finding
cites the standard it deviates from — a rule file, the template table, or a