Fix all 6 confirmed findings from today's gap audit

Implements every confirmed finding from the workflow-based audit of
CURABIS Standard's agent model (7 finders + adversarial verification,
8 confirmed / 5 refuted):

1. Roemer/Florence phantom wiring - roemer.agent.md claimed Florence's
   heartbeat "may summon me when a ward smells of drift" with nothing in
   florence.agent.md or HEARTBEAT.md implementing it. Fixed by adding an
   explicit "Kald Roemer" instruction to HEARTBEAT.md ward 6 (agent
   visibility, his actual domain), mirroring ward 8's existing "Kald
   Weber" pattern, and correcting roemer.agent.md's own claim to match.

2. m365.agent.md's "Florence's morning brief pattern" was a one-way
   orphaned reference - a full 4-step pattern with nothing in
   florence.agent.md implementing it. Added it to florence.agent.md as
   an explicit on-demand capability, separate from the timestamp-gated
   Round protocol.

3. An Ergasterion "PROCEED WITH CHANGES" ruling had no way to be checked
   against the eventual diff - al-review's checklists never referenced
   it. Added ERGASTERION_RULING to the [CURABIS-STATE] vocabulary,
   wired Ergasterion to write it, and added a BLOCKing checklist item to
   al-review's Titus checklist that verifies required changes were
   actually implemented.

4. curabis-task-state-check.yml was headered "Deterministic enforcement
   (not LLM diligence)" but only checks checkbox order, only blocks
   anything if a human separately enabled branch protection (never
   verified anywhere), and doesn't exist at all for the PTE track.
   Corrected the header's claims and added Roemer station 14 to verify
   branch protection is actually configured.

5. Mode C's only safeguard against a support user reaching
   Curabis/QualityHub was a single manual eyeball check with no re-check
   ever. Strengthened Step 2 to cover team-inherited and org-default
   access paths, added an append-only support-user registry, and added
   Roemer station 15 to periodically re-verify every registered user
   against it.

6. Columbo's persona was presented as genuine autobiography with no
   disclosure of its fictional TV origin (Levinson & Link, Peter Falk),
   unlike Smiley which discloses explicitly. Added a reader-facing
   editorial note - never something Columbo says aloud, since unlike
   Smiley he actually performs the persona to customers.
This commit is contained in:
Michael Dieringer 2026-08-03 14:12:05 +02:00
parent 44546d4fe0
commit 9e5273443f
11 changed files with 181 additions and 18 deletions

View file

@ -1,11 +1,37 @@
name: CURABIS task-state check
# Deterministic enforcement (not LLM diligence) for the AppSource state-trail
# format from task-state-lives-in-the-mandatory-artifact.md. Parses the PR
# body for a "## CURABIS Task State" checklist and fails if any checked box
# appears AFTER an unchecked one - i.e. a later stage claimed without an
# earlier one. Silently passes (does nothing) if the section is absent -
# this check only applies to PRs that actually opted into the state trail;
# 2026-08-03 - scope correction after an audit found the header overstated
# this check's actual guarantee.
#
# What this DOES enforce deterministically: checklist ORDER in the PR body
# ("## CURABIS Task State") - a later stage cannot be checked while an
# earlier one isn't. It runs on every push/edit, needs no AI session to
# execute, and cannot be talked out of failing.
#
# What this does NOT enforce, and never has: that a checked box corresponds
# to a real event (a red test that actually ran, a review that actually
# happened). A session or a rushed developer can check every box in perfect
# order having done none of the underlying work, and this Action passes.
# The order check catches a narrower, still-real failure mode (a later
# stage claimed before an earlier one) - it is not proof the trail is true.
#
# This ALSO does not enforce anything by itself unless a human has
# separately added it as a required status check in the repo's branch
# protection settings (curabis-standard.agent.md documents this as a
# one-time manual step - it cannot be automated by file deployment). Absent
# that, a failing run just shows as a red X someone can ignore and merge
# past. Rømer's inspection round has a station that checks whether branch
# protection is actually configured this way - see roemer.agent.md station 14.
#
# This check ONLY covers the AppSource track (PR body checklists). The PTE
# track (BC task comments) has NO equivalent deterministic backstop - only
# Smiley's Close-gate self-verification and al-review's "state trail
# complete?" checklist item, both of which are an AI session re-reading its
# own/BC's history, not an independent script. That is a known, accepted
# gap, not an oversight - see task-state-lives-in-the-mandatory-artifact.md.
#
# Silently passes (does nothing) if the "## CURABIS Task State" section is
# absent - this check only applies to PRs that opted into the state trail;
# it must never block an unrelated PR (docs fix, infra change, etc.).
on: