mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
Tilfoej al-review: uafhaengig per-aendring-reviewer (Torvalds + Winters)
Fjerde gate i Task Lifecycle - koert efter groent test, foer merge, adskilt fra den der implementerede aendringen og fra Roemer/Immanuel/Court's portefoelje-niveau-styring (de spoerger "er selve regelsaettet sundt", ikke "er DENNE aendring god"). To linser, Michaels egen opdeling: - Linus Torvalds: BC/AL-domaene-teknisk (respekterer standard-BC/events, bogfoerings-sideeffekter, opgraderings-holdbarhed, filtre/keys/SetLoadFields, locking/SQL-performance, permissions/dataklassifikation, forretningslogik paa forkert sted, testdaekning af forretningsforloeb, lokalt rigtig men arkitektonisk forkert) - Titus Winters: generel software-engineering (korrekthed, forstaaelighed, arkitektonisk sammenhaeng, testbarhed, cyklomatisk/McCabe-kompleksitet - ingen anden i rosteret vurderer det tal - Hyrum's Law, kodebase-konsistens, boer det overhovedet bygges saadan) Wired ind i Smileys Close gate (samme udfaldsbaserede disciplin som resten af dagens rettelser) - ikke noget udvikleren skal huske at bede om. Verdict er APPROVE / APPROVE WITH NOTES / BLOCK, aldrig en fjerde "det er kompliceret". Roster-taeller opdateret alle steder: 22 agent-filer i alt (20 maskin-globale, 2 repo-lokale), 19 filer i ~/.claude/curabis-agents/. sync-bcquality- knowledge.ps1 testet - al-review.agent.md bekraeftet leveret. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
parent
b54bf88d7b
commit
9d0a1d2d47
5 changed files with 168 additions and 15 deletions
|
|
@ -94,9 +94,16 @@ These are invoked only when needed - not at session start:
|
|||
- `~/.claude/curabis-agents/al-triage.agent.md` - reactive diagnosis when a build, test, or runtime
|
||||
is already broken. Reproduce -> root-cause -> minimal-fix. Read-only; it recommends,
|
||||
it does not apply. Invoke when the user reports an error, a failing test, or a regression.
|
||||
- `~/.claude/curabis-agents/al-complexity.agent.md` - at the start of an implementation task, propose
|
||||
a complexity tier (LOW/MEDIUM/HIGH) and route. Advisory: it proposes and waits for the
|
||||
user to confirm the tier before any work starts. Never routes or codes on its own.
|
||||
- `~/.claude/curabis-agents/al-complexity.agent.md` - before any tier is proposed, checks Microsoft
|
||||
Learn + the BCApps reference clone for whether Business Central already solves the
|
||||
requirement natively (STANDARD tier, no code). Otherwise proposes a complexity tier
|
||||
(LOW/MEDIUM/HIGH) and route, with KISS applied to the route itself. Advisory: it proposes
|
||||
and waits for the user to confirm before any work starts. Never routes or codes on its own.
|
||||
- `~/.claude/curabis-agents/al-review.agent.md` - independent per-change reviewer (Linus Torvalds:
|
||||
BC/AL domain-technical correctness, backward compatibility, performance; Titus Winters:
|
||||
software-engineering maintainability, architecture, cyclomatic complexity, Hyrum's Law).
|
||||
Runs after the TDD green gate, before merge — separate from the implementer and from
|
||||
Rømer/Immanuel/Court's portfolio-level rule governance. Findings only, never rewrites code.
|
||||
- `~/.claude/curabis-agents/bc-mcp.agent.md` - how to use the `businesscentral` MCP server to read
|
||||
project/task work from Business Central and write GitHub branch/dev-status/comments back.
|
||||
Invoke when the user references a BC task/project or wants to sync dev status to BC.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue