UI knowledge: notification recall needs a known Id; open mixed-type documents through Page Management (#214)

* Add UI knowledge: notification recall Id and Page Management document routing Two ui articles with compiled good/bad samples: - notification-recall-needs-known-id: a notification that the code also recalls needs a fixed Id (single instance; recall before re-send) or per-record tracking through codeunit "Notification Lifecycle Mgt." (SendNotification[WithAdditionalContext] / RecallNotificationsForRecord, HandleDelayedInsert semantics). Never-recalled notifications are exempt. - list-page-document-routing-uses-page-management: open documents from a mixed-type list with PageManagement.PageRun(Rec) instead of a hand-written case "Document Type" / Page.Run; register new tables through OnConditionalCardPageIDNotFound. Single-type opens and tables Page Management does not route are exempt. Wired into al-ui-review (entry gate now covers notification send/recall outside pages, tokens, high-signal mappings) and registered both pairs in the ui review-fixtures override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address review: scope shared notification Ids, routed-table definition, pinned links - notification-recall-needs-known-id: a fixed Id shared across records is valid for one-at-a-time warnings (Sales Line blocked-item, Over-Receipt Mgt. pass a fixed Id to SendNotification after Recall); the per-record anti-pattern now requires several records' notifications to be visible at once. Recall wording follows Learn (including its false-return reasons) and cites Base App's recall-before-send practice. - list-page-document-routing-uses-page-management: definition covers opening a routed table directly or after Get; cite archive line lists, Copy Document Mgt. ShowSalesDoc/ShowPurchDoc and Office handler; no "document types added later" overclaim (GetSalesHeaderPageID has no else for the extensible enum); full GetPageID resolution order; drop the IRS single-page subscriber. - al-ui-review: non-page files admitted by the notification clause are checked only against notification knowledge; description updated; drop the "Document Type" token; case-insensitive token matching; cues aligned with both articles. - Pin BCApps links to 837ef802485ee457e52310d2ecaa08b93d0122fd. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address review: notification recall defect is a lost identity, not an unassigned or generated Id - notification-recall-needs-known-id: the defect is a Recall() whose Id cannot be the sent one (fresh local Notification, new CreateGuid at recall time) while neither the sent instance nor its Id is kept. A retained global instance (CreateGuid once in OnOpenPage, or Id left for Send to assign), a generated Id saved after Send and reassigned before Recall, and correctly tracked per-record Ids are explicitly not findings. Findings require evidence that the recalled identity differs from or cannot recover the sent identity. Notification Lifecycle Mgt. is recommended for per-record tracking, not mandatory. Cites VAT Bus. Post. Grp. Part, Certificate, and Data Search Lines, and the lifecycle helper's Send-then-read-Id sequence. - good sample: adds a page with a retained global Notification (CreateGuid in OnOpenPage, Send in an action, Recall in a later action and OnClosePage) and a pageextension that saves the Send-assigned Id and recalls it from a later action. Bad sample comments name the lost identity. - al-ui-review: notification cue requires that evidence and lists the retained-instance, saved-Id, and direct per-record tracking controls as exclusions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 07:36:54 +01:00 · 2026-10-06 13:30:59 +02:00 · 2026-10-06 13:30:59 +02:00 · 86d809b525
commit 86d809b525
parent 018e62767d
8 changed files with 365 additions and 7 deletions
--- a/microsoft/knowledge/ui/notification-recall-needs-known-id.good.al
+++ b/microsoft/knowledge/ui/notification-recall-needs-known-id.good.al
@ -0,0 +1,145 @@
+pageextension 50720 "Sample Customer Card Ext" extends "Customer Card"
+{
+    trigger OnAfterGetCurrRecord()
+    var
+        NoCreditLimitNotification: Notification;
+    begin
+        // A fixed Id lets this code recall the notification it sent earlier.
+        NoCreditLimitNotification.Id := GetNoCreditLimitNotificationId();
+        NoCreditLimitNotification.Recall();
+        if Rec."Credit Limit (LCY)" = 0 then begin
+            NoCreditLimitNotification.Message := NoCreditLimitMsg;
+            NoCreditLimitNotification.Scope := NotificationScope::LocalScope;
+            NoCreditLimitNotification.Send();
+        end;
+    end;
+
+    local procedure GetNoCreditLimitNotificationId(): Guid
+    begin
+        exit('6f0c2b8e-4a1d-4f7e-9b3a-2d5e8c1f7a40');
+    end;
+
+    var
+        NoCreditLimitMsg: Label 'This customer has no credit limit.';
+}
+
+page 50721 "Sample Credit Review"
+{
+    PageType = Card;
+    SourceTable = Customer;
+    Caption = 'Credit Review';
+
+    layout
+    {
+        area(Content)
+        {
+            field("No."; Rec."No.")
+            {
+                ApplicationArea = All;
+                ToolTip = 'Specifies the number of the customer.';
+            }
+        }
+    }
+
+    actions
+    {
+        area(Processing)
+        {
+            action(FlagForReview)
+            {
+                ApplicationArea = All;
+                Caption = 'Flag for Review';
+                ToolTip = 'Shows a reminder that this customer needs a credit review.';
+
+                trigger OnAction()
+                begin
+                    if ReviewNotification.Recall() then;
+                    ReviewNotification.Message := ReviewNeededMsg;
+                    ReviewNotification.Scope := NotificationScope::LocalScope;
+                    ReviewNotification.Send();
+                end;
+            }
+            action(ClearReviewFlag)
+            {
+                ApplicationArea = All;
+                Caption = 'Clear Review Flag';
+                ToolTip = 'Removes the credit review reminder.';
+
+                trigger OnAction()
+                begin
+                    // The same global instance that was sent carries its Id here.
+                    if ReviewNotification.Recall() then;
+                end;
+            }
+        }
+    }
+
+    trigger OnOpenPage()
+    begin
+        // A generated Id is fine: it is assigned once and kept with the instance.
+        ReviewNotification.Id := CreateGuid();
+    end;
+
+    trigger OnClosePage()
+    begin
+        if ReviewNotification.Recall() then;
+    end;
+
+    var
+        ReviewNotification: Notification;
+        ReviewNeededMsg: Label 'This customer needs a credit review.';
+}
+
+pageextension 50722 "Sample Customer List Ext" extends "Customer List"
+{
+    actions
+    {
+        addlast(Processing)
+        {
+            action(SampleShowStatementReminder)
+            {
+                ApplicationArea = All;
+                Caption = 'Show Statement Reminder';
+                ToolTip = 'Shows a reminder to send statements to the selected customers.';
+
+                trigger OnAction()
+                var
+                    ReminderNotification: Notification;
+                begin
+                    RecallStatementReminder();
+                    ReminderNotification.Message := StatementReminderMsg;
+                    ReminderNotification.Scope := NotificationScope::LocalScope;
+                    ReminderNotification.Send();
+                    // Send assigned the Id; saving it lets a later action recall it.
+                    LastReminderNotificationId := ReminderNotification.Id;
+                end;
+            }
+            action(SampleDismissStatementReminder)
+            {
+                ApplicationArea = All;
+                Caption = 'Dismiss Statement Reminder';
+                ToolTip = 'Removes the statement reminder.';
+
+                trigger OnAction()
+                begin
+                    RecallStatementReminder();
+                end;
+            }
+        }
+    }
+
+    local procedure RecallStatementReminder()
+    var
+        ReminderNotification: Notification;
+    begin
+        if IsNullGuid(LastReminderNotificationId) then
+            exit;
+        ReminderNotification.Id := LastReminderNotificationId;
+        if ReminderNotification.Recall() then;
+        Clear(LastReminderNotificationId);
+    end;
+
+    var
+        LastReminderNotificationId: Guid;
+        StatementReminderMsg: Label 'Remember to send statements to the selected customers.';
+}