mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
Normalize SCM knowledge and review ownership
Align article and AL sample conventions, keep BC facts separate from review mechanics, and clarify reciprocal Finance ownership without bespoke shared test assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
parent
9ac62e3967
commit
525e84e183
30 changed files with 148 additions and 362 deletions
22
.github/scripts/Test-SkillIndex.ps1
vendored
22
.github/scripts/Test-SkillIndex.ps1
vendored
|
|
@ -110,28 +110,6 @@ try {
|
|||
}
|
||||
}
|
||||
|
||||
$scm = @($skills | Where-Object id -eq 'al-scm-review')
|
||||
if ($scm.Count -ne 1 -or
|
||||
(@($scm[0].inputs) -join ',') -cne 'pr-diff,file-path,folder-path' -or
|
||||
(@($scm[0].filters.technologies) -join ',') -cne 'al') {
|
||||
throw 'SCM must be discoverable as an AL leaf accepting diffs, files, and complete folders.'
|
||||
}
|
||||
$scmText = Get-Content -LiteralPath (Join-Path $Root $scm[0].path) -Raw
|
||||
$scmExamples = [regex]::Matches($scmText, '(?s)```json\s*(\{.*?\})\s*```')
|
||||
if ($scmExamples.Count -ne 2) {
|
||||
throw "Expected two SCM findings-report examples, found $($scmExamples.Count)."
|
||||
}
|
||||
foreach ($example in $scmExamples) {
|
||||
if (-not ($example.Groups[1].Value | Test-Json -SchemaFile $reportSchema -ErrorAction Stop)) {
|
||||
throw 'An SCM output example does not satisfy schemas/findings-report.schema.json.'
|
||||
}
|
||||
$report = $example.Groups[1].Value | ConvertFrom-Json
|
||||
if ($report.skill.id -cne 'al-scm-review' -or
|
||||
@($report.findings | Where-Object domain -cne 'Supply Chain Management').Count) {
|
||||
throw 'SCM output examples must retain the leaf id and complete display domain.'
|
||||
}
|
||||
}
|
||||
|
||||
$minimalReport = @{
|
||||
skill = @{ id = 'al-style-review'; version = 1 }
|
||||
outcome = 'completed'
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue