Microsoft/bcquality
1
0
Fork 0
mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-07 15:46:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

knowledge(upgrade): upgrade code must not use ChangeCompany

Browse source 
Addresses ADO bug 651092. Upgrade and feature data update code must run in the
context of the company being upgraded; ChangeCompany leaves triggers, events and
upgrade tags in the calling company and races the target company's own upgrade.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Jesper Schulz-Wedde 2026-10-02 10:11:49 +02:00
parent 0867171b1a
commit 4e33ca87e2
5 changed files with 96 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

24
microsoft/knowledge/upgrade/no-changecompany-in-upgrade.bad.al Normal file
View file

@ -0,0 +1,24 @@
codeunit 50261 "Upgrade All Companies"
{
Subtype = Upgrade;
trigger OnUpgradePerDatabase()
var
Company: Record Company;
SalesOrderExt: Record "Sales Order Ext";
begin
// Reaches into every company from one session. Each company also has its own
// upgrade session, triggers and subscribers run in the calling context, and a
// data error in any company aborts the whole upgrade.
if Company.FindSet() then
repeat
SalesOrderExt.ChangeCompany(Company.Name);
SalesOrderExt.SetRange("Shipping Agent Code", '');
if SalesOrderExt.FindSet(true) then
repeat
SalesOrderExt.Validate("Shipping Agent Code", SalesOrderExt."Legacy Carrier Code");
SalesOrderExt.Modify(true);
until SalesOrderExt.Next() = 0;
until Company.Next() = 0;
end;
}