Strengthen review contracts and add AL reliability guidance (#196)

* Strengthen review contracts and HTTP guidance - add outbound HttpClient transport and HTTP status review rules with paired fixtures`n- resolve layered action-skill overrides deterministically across enabled layers`n- validate findings reports and enforce measurable changed-fixture coverage * Add data handling and test isolation guidance - add SCM guidance for deriving base quantities through line unit-of-measure validation`n- add security guidance for parameterizing SetFilter with external text`n- add test isolation guidance for resetting per-test state before initialization guards`n- add web-service guidance for JSON null handling and invariant standard format 9`n- route and cover all five rules with paired evaluation fixtures * Fix findings report rollup validation * Validate findings report rollups * Enforce merged finding identity * Fix locationless finding deduplication * Reject conflicting merged corrections * Detect conflicting leaf corrections * Route HTTP error checks to canonical web-services knowledge Let the Error Handling leaf conditionally retrieve the existing HTTP owner articles, preserving applicability and exact-path provenance. Add deterministic source-contract and retrieval regressions without duplicating knowledge rules. Copilot-Session-Id: a92a7788-103e-4651-9b84-19e34caffb94 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: wenjiefan <wenjiefan@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
2026-10-05 14:46:55 +01:00 · 2026-09-29 13:03:39 +02:00 · 2026-09-29 13:03:39 +02:00 · 4287233f80
commit 4287233f80
parent 130d5de6c4
41 changed files with 1974 additions and 38 deletions
--- a/microsoft/knowledge/testing/reset-per-test-state-before-the-isinitialized-guard.bad.al
+++ b/microsoft/knowledge/testing/reset-per-test-state-before-the-isinitialized-guard.bad.al
@ -0,0 +1,57 @@
+codeunit 50411 "Test Sales Setup Initialize Bad"
+{
+    Subtype = Test;
+
+    [Test]
+    [HandlerFunctions('CustomerCardHandler')]
+    procedure CustomerCardOpensForSelectedCustomer()
+    var
+        Customer: Record Customer;
+    begin
+        Initialize();
+        LibrarySales.CreateCustomer(Customer);
+        LibraryVariableStorage.Enqueue(Customer."No.");
+
+        Page.RunModal(Page::"Customer Card", Customer);
+
+        LibraryVariableStorage.AssertEmpty();
+    end;
+
+    [Test]
+    procedure StockoutWarningCanBeDisabled()
+    var
+        SalesSetup: Record "Sales & Receivables Setup";
+    begin
+        Initialize();
+
+        LibrarySales.SetStockoutWarning(false);
+
+        SalesSetup.Get();
+        Assert.IsFalse(SalesSetup."Stockout Warning", 'The stockout warning was not disabled.');
+    end;
+
+    local procedure Initialize()
+    begin
+        if IsInitialized then
+            exit;
+
+        LibraryVariableStorage.Clear();
+        LibrarySetupStorage.Restore();
+        LibrarySales.SetStockoutWarning(true);
+        IsInitialized := true;
+        LibrarySetupStorage.SaveSalesSetup();
+    end;
+
+    [ModalPageHandler]
+    procedure CustomerCardHandler(var CustomerCard: TestPage "Customer Card")
+    begin
+        Assert.AreEqual(LibraryVariableStorage.DequeueText(), CustomerCard."No.".Value(), 'The customer card opened for the wrong customer.');
+    end;
+
+    var
+        Assert: Codeunit Assert;
+        LibrarySales: Codeunit "Library - Sales";
+        LibrarySetupStorage: Codeunit "Library - Setup Storage";
+        LibraryVariableStorage: Codeunit "Library - Variable Storage";
+        IsInitialized: Boolean;
+}