From 11eab5772348bd00ea4b1ca3122f529aa8c9936d Mon Sep 17 00:00:00 2001
From: Michael Dieringer <65093775+MichaelDieringer@users.noreply.github.com>
Date: Thu, 2 Jul 2026 08:04:22 +0200
Subject: [PATCH] Edison sharpening runde 1: to regler faar skarpe kanter (Type
 A)

Foerste eval-runde nogensinde (korpus: Jernpladsen @ b7656b1, 36 pages,
77 testprocedurer) fandt to regler med uskarpe graenser:

- pages-must-not-contain-business-logic: undtagelse 3 tilfoejet -
  singleton-init-idiomet paa Cue/Activities-pages (if not Get then
  Init+Insert i OnOpenPage) er praesentations-bootstrap, ikke
  forretningslogik. Basisappen bruger samme moenster paa alle cue-pages.
  Evidens: reglen flagede ScrapDealerActivities; adjudikeret FP.
  Precision som skrevet: 0,67 (2 TP / 1 FP) - de to TP'er staar ved magt.

- test-one-when-per-test: flow-test-graensen defineret. Multi-WHEN er
  tilladt naar navnet deklarerer flowet, hver WHEN er en runde af EET
  scenarie, og THEN asserter den akkumulerede sluttilstand. Unit-tests
  beholder streng een-WHEN. Evidens: 5 bevidst runde-maerkede
  procedurer i SVPartialFlowTests, som reglen ikke kunne doemme.

Scorecards i PR-beskrivelsen. Rute: Edison -> Francis (Type A) ->
Immanuel -> Michael, jf. edison.agent.md Step 6.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 .../pages-must-not-contain-business-logic.md  |  8 +++++-
 .../testing/test-one-when-per-test.md         | 25 +++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/custom/knowledge/architecture/pages-must-not-contain-business-logic.md b/custom/knowledge/architecture/pages-must-not-contain-business-logic.md
index 04c4592..f8cd04f 100644
--- a/custom/knowledge/architecture/pages-must-not-contain-business-logic.md
+++ b/custom/knowledge/architecture/pages-must-not-contain-business-logic.md
@@ -18,10 +18,16 @@ In CURABIS codebases, pages serve exclusively as presentation layers. All busine
 
 ## Permitted Exceptions
 
-Two specific scenarios allow deviation from this rule:
+Three specific scenarios allow deviation from this rule:
 
 1. **Setup Pages**: May directly read and write their own setup records
 2. **Conversion Pages**: The designated "Run Conversion" page may invoke the conversion codeunit directly
+3. **Cue/Activities Pages**: The standard singleton-initialization idiom in
+   `OnOpenPage` — `if not Rec.Get() then begin Rec.Init(); Rec.Insert(); end` —
+   is permitted. It bootstraps the page's own presentation-state record and is
+   the same pattern Microsoft uses on every base-app cue page; it is not
+   business logic. (Edison eval 2026-07-02, Jernpladsen @ b7656b1: the rule
+   flagged this idiom on an Activities page; adjudicated false positive.)
 
 ## Anti-Pattern Examples
 
diff --git a/custom/knowledge/testing/test-one-when-per-test.md b/custom/knowledge/testing/test-one-when-per-test.md
index d01d472..ffe0790 100644
--- a/custom/knowledge/testing/test-one-when-per-test.md
+++ b/custom/knowledge/testing/test-one-when-per-test.md
@@ -71,6 +71,29 @@ belongs in `[WHEN]`.
         Assert.AreEqual(1, TempBuffer.Count(), 'Exactly one tier line expected');
     end;
 
+## Flow tests — the deliberate exception
+
+A **flow test** verifies the accumulated outcome of a multi-round business
+flow — partial receipt then invoicing, multiple posting rounds against one
+document. Here the sequence IS the scenario: the claim under test is "after
+round 1, 2 and 3, the balances are correct", and it cannot be expressed as
+three independent tests without losing the very interaction being verified.
+
+Flow tests are permitted with multiple `[WHEN]` blocks when ALL of these hold:
+
+1. The name declares the flow: the codeunit or procedure name contains the
+   sequence (`SVPartialFlowTests`, `ReceiveThenInvoice_QuantitiesAreCorrect`).
+2. Each `[WHEN]` is labelled as a round of ONE scenario ("Runde 1: kun
+   modtagelse"), not as an unrelated action.
+3. The `[THEN]` asserts the accumulated end-state — not one unrelated claim
+   per WHEN. If the assertions decompose cleanly per action, it is two tests
+   in disguise: split.
+
+Unit-level tests keep the strict one-WHEN rule without exception. (Edison
+eval 2026-07-02, Jernpladsen @ b7656b1: five multi-WHEN procedures in
+SVPartialFlowTests, all deliberate round-labelled flows — the rule previously
+gave no verdict on them.)
+
 ## Naming implication
 
 The procedure name should make the single WHEN self-evident.
@@ -78,3 +101,5 @@ A name with "And" or "Then" in the middle is a strong signal to split:
 
 - `GetPrice_AndDiscount_ReturnsValues` → split
 - `GetPrice_CustomerPrice_ReturnsUnitPrice` → good
+- `ReceiveThenInvoice_QuantitiesAreCorrect` → legitimate flow test IF the
+  flow-test conditions above are met