mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 22:56:55 +01:00
Support complete app folder reviews
Define folder-path as a current-state review scope and accept it across the standalone adapter, broad coordinator, and every AL review leaf. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
parent
272c1222c2
commit
09327d80f1
22 changed files with 78 additions and 39 deletions
|
|
@ -1,6 +1,6 @@
|
|||
---
|
||||
name: al-code-review
|
||||
description: Review Business Central AL code changes using BCQuality's curated rules. Use for an AL pull request, working-tree diff, branch, or individual AL file when BCQuality is installed as a standalone plugin.
|
||||
description: Review Business Central AL code using BCQuality's curated rules. Use for an AL app folder, pull request, working-tree diff, branch, or individual AL file when BCQuality is installed as a standalone plugin.
|
||||
---
|
||||
|
||||
# AL code review
|
||||
|
|
@ -21,8 +21,11 @@ context and execute the resulting dispatch.
|
|||
- Copy the caller's actual request verbatim into `goal`; do not replace a
|
||||
focused request such as "review performance" with a generic full-review
|
||||
goal.
|
||||
- Set `inputs-available` to the inputs actually available to the review,
|
||||
normally `pr-diff` for changes or `file-path` for one file.
|
||||
- Set `inputs-available` to the inputs actually available to the review:
|
||||
`folder-path` for an app or source folder, `pr-diff` for changes, or
|
||||
`file-path` for one file. Pass the caller's actual path with the selected
|
||||
input type; for a whole-app request in the current working directory, use
|
||||
that directory as the `folder-path`.
|
||||
- Set `technologies: [al]` when the input is known to be AL.
|
||||
- Pass `bc-version`, `countries`, and `application-area` only when supplied
|
||||
or reliably determined.
|
||||
|
|
@ -66,4 +69,3 @@ where a consumer prunes its checkout to policy before the agent runs and the
|
|||
index is rebuilt over the pruned tree. Treat `BCQUALITY_ENABLED_LAYERS` as a
|
||||
selection filter, never as a security boundary. A host that needs a genuine
|
||||
deny mechanism must prune the installed tree itself.
|
||||
|
||||
|
|
|
|||
19
skills/do.md
19
skills/do.md
|
|
@ -56,7 +56,24 @@ application-area: [all]
|
|||
|
||||
`bc-version`, `technologies`, `countries`, `application-area` are optional filters that let an orchestrator pre-select applicable skills for a task. They follow the same semantics as in READ.
|
||||
|
||||
`inputs` is a list of abstract input types the skill **accepts**. Standard values: `pr-diff`, `object-list`, `file-path`, `repository`, `telemetry-query`. Semantics are any-of: the orchestrator supplies whichever listed input types it has, and the skill is invoked with a non-empty subset of its declared `inputs`. A skill that cannot proceed with the supplied subset MUST return `outcome: "not-applicable"`. `outputs` is always a single-element list naming the output kind; today only `findings-report` is defined.
|
||||
`inputs` is a list of abstract input types the skill **accepts**. Standard values:
|
||||
`pr-diff`, `object-list`, `file-path`, `folder-path`, `repository`, and
|
||||
`telemetry-query`. Semantics are any-of: the orchestrator supplies whichever
|
||||
listed input types it has, and the skill is invoked with a non-empty subset of
|
||||
its declared `inputs`. A skill that cannot proceed with the supplied subset
|
||||
MUST return `outcome: "not-applicable"`. `outputs` is always a single-element
|
||||
list naming the output kind; today only `findings-report` is defined.
|
||||
|
||||
`file-path` is one file. `folder-path` is a directory whose recursively
|
||||
contained files form the complete current-state input, such as a Business
|
||||
Central app folder containing `app.json` and AL source. The input value is the
|
||||
actual path, not merely the name of the input type. The agent MUST enumerate
|
||||
the folder rather than reducing it to one representative file.
|
||||
|
||||
Review skills use terms such as "diff", "changed files", and "changed code" as
|
||||
shorthand for the supplied review scope. For `folder-path`, every relevant file
|
||||
under the folder is in scope. A folder supplies no historical baseline:
|
||||
comparison-only rules MUST NOT infer a prior state that was not provided.
|
||||
|
||||
`sub-skills` is an optional field. When present and non-empty, the skill is a **super-skill** that composes other action skills; see *Composition* below. Values are repo-relative paths to action-skill files.
|
||||
|
||||
|
|
|
|||
|
|
@ -23,6 +23,7 @@ task-context:
|
|||
inputs-available: # values the orchestrator has ready to pass to a chosen skill
|
||||
- pr-diff
|
||||
- file-path
|
||||
- folder-path
|
||||
technologies: [al]
|
||||
bc-version: 28
|
||||
countries: [w1]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue