mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
Add source-verified Finance knowledge and review domain (#57)
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Validate skill index and report schemas / validate-contract (push) Has been cancelled
Validate frontmatter and structure / validate (push) Has been cancelled
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Validate skill index and report schemas / validate-contract (push) Has been cancelled
Validate frontmatter and structure / validate (push) Has been cancelled
* Add Finance posting domain-knowledge pilot Adds three atomic domain-rule knowledge files under community/knowledge/finance/ as a pilot for Type-A (normative) Business Central domain knowledge: post through the posting engine, treat posted ledger entries as immutable, and treat the Dimension Set ID as the source of truth for dimensions. Includes a good/bad AL sample pair for the posting rule. These encode BC-specific invariants that LLMs reliably get wrong, fitting the existing remedial/atomic knowledge grain with no schema or contract changes. Passes the repo frontmatter validator and is discovered by the knowledge index. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify editable operational fields on posted ledger entries Addresses review feedback from @JeremyVyska on PR #57: the immutability rule applies to financial content, not the whole entry. Reframes the Description around financial content and gives the operational-field exception (payment/application data, on-hold, applies-to, communication fields edited via CustEntry-Edit/VendEntry-Edit and the ledger entry pages) its own paragraph in Best Practice instead of understating it as a narrow set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Expand Finance pilot into a source-verified review domain Move Finance knowledge to the Microsoft-owned layer, add nine scoped rules with eighteen AL samples, and register bounded Finance review with complete paired evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix Finance review applicability and ownership boundaries Remove application-area gating and later VAT-field dependencies, align dynamic shared conventions, separate SCM ownership, and keep journal examples focused on the intended invariant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove logo branding (#194) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add title and description to README * Add foundational AL developer knowledge (#195) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify locale-safe DateFormula Evaluate inputs (#193) * Clarify locale-safe DateFormula Evaluate inputs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize DateFormula article sections Keep the analyzer-gap explanation in Description and its scoped probe evidence in References, without a novel Validation section. Normative guidance and fixtures are unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add SCM functional knowledge domain (#192) * Add SCM functional knowledge domain Introduce nine source-backed rules with original AL sample pairs, bounded SCM review routing, and complete positive/clean evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize SCM knowledge and review ownership Align article and AL sample conventions, keep BC facts separate from review mechanics, and clarify reciprocal Finance ownership without bespoke shared test assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
parent
bec8890b7e
commit
07e324ddbc
33 changed files with 1084 additions and 1 deletions
|
|
@ -211,6 +211,16 @@ mutations belong to Finance, even when that domain is not enabled. Equivalent
|
|||
findings for one inventory-originated posting bypass have one SCM primary
|
||||
owner; distinct independent financial defects remain separate.
|
||||
|
||||
The Finance leaf reviews journal posting, financial ledger changes,
|
||||
applications, and posting-linked dimension handling. It prunes unrelated code
|
||||
at the leaf rather than changing broad-review orchestration. Finance articles
|
||||
use `application-area: [all]` so missing application-area context does not
|
||||
weaken applicable findings; resolved records and operations supply the
|
||||
narrowing. Finance owns financial ledgers, not Item, Value, Capacity, Warehouse,
|
||||
or inventory-application records owned by SCM. It also does not own generic
|
||||
custom-table or master Default Dimension wiring. Request a focused "Finance
|
||||
posting review" when only this domain is needed.
|
||||
|
||||
BCQuality intentionally does not duplicate mechanical diagnostics already
|
||||
enforced by the AL compiler or standard analyzers. Run the consuming app's
|
||||
normal compiler and analyzer pipeline alongside review and authoring. Knowledge
|
||||
|
|
@ -230,6 +240,7 @@ Each article describes one concern. Where samples exist, use its linked
|
|||
| Data modeling | [Data modeling](../microsoft/knowledge/data-modeling/) |
|
||||
| Error handling | [Error handling](../microsoft/knowledge/error-handling/) |
|
||||
| Events | [Events](../microsoft/knowledge/events/) |
|
||||
| Finance | [Finance](../microsoft/knowledge/finance/) |
|
||||
| Interfaces | [Interfaces](../microsoft/knowledge/interfaces/) |
|
||||
| Performance | [Performance](../microsoft/knowledge/performance/) |
|
||||
| Privacy | [Privacy](../microsoft/knowledge/privacy/) |
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue