Merge branch 'microsoft:main' into main
This commit is contained in:
commit
e49c2af933
8 changed files with 26 additions and 28 deletions
|
|
@ -71,7 +71,7 @@ Of course it is possible to have a single object as a central place to emit tele
|
|||
|
||||
## Candidate data for telemetry
|
||||
|
||||
Telemetry must be **actionable** for the customer. Do not emit signals that they cannot act on (knowing about CPU performance counters on the database is useless if the partner cannot scale the database)
|
||||
Telemetry must be **actionable** for the customer. Do not emit signals that they cannot act on (knowing about CPU performance counters on the database is useless if the partner cannot scale the database).
|
||||
|
||||
Also, note that customers pay for data ingestion. So be mindful to not flood their telemetry resources. Consider to use TelemetryScope::ExtensionPublisher by default and only use TelemetryScope::All in case the customer can also act on the data.
|
||||
|
||||
|
|
|
|||
|
|
@ -166,7 +166,7 @@ It is common use to give certain fields a more describing name. Some examples ar
|
|||
These fields should always be part of the API Page:
|
||||
|
||||
* SystemId
|
||||
* This field should be exposed wit the name ```id```
|
||||
* This field should be exposed with the name ```id```
|
||||
* SystemModifiedAt
|
||||
* This field should be exposed with the name ```lastModifiedDateTime```. If you choose a different name, then the webhook functionality will not work properly.
|
||||
|
||||
|
|
@ -179,8 +179,8 @@ layout
|
|||
{
|
||||
repeater(records)
|
||||
{
|
||||
field(id; SystemId) { }
|
||||
field(lastModifiedDateTime; SystemModifiedAt) { }
|
||||
field(id; Rec.SystemId) { }
|
||||
field(lastModifiedDateTime; Rec.SystemModifiedAt) { }
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -15,7 +15,7 @@ When `begin` follows `then`, `else`, `do`, it should be on the same line, preced
|
|||
```al
|
||||
if ICPartnerRefType = ICPartnerRefType::"Common Item No." then
|
||||
begin
|
||||
...
|
||||
...
|
||||
end;
|
||||
```
|
||||
|
||||
|
|
@ -23,7 +23,6 @@ When `begin` follows `then`, `else`, `do`, it should be on the same line, preced
|
|||
|
||||
```al
|
||||
if ICPartnerRefType = ICPartnerRefType::"Common Item No." then begin
|
||||
...
|
||||
...
|
||||
end;
|
||||
```
|
||||
|
||||
|
|
|
|||
|
|
@ -13,7 +13,7 @@ Only use begin..end to enclose [compound statements](https://docs.microsoft.com/
|
|||
```AL
|
||||
if FindSet() then begin
|
||||
repeat
|
||||
...
|
||||
...
|
||||
until next() = 0;
|
||||
end;
|
||||
```
|
||||
|
|
@ -23,7 +23,7 @@ end;
|
|||
```AL
|
||||
if FindSet() then
|
||||
repeat
|
||||
...
|
||||
...
|
||||
until next() = 0;
|
||||
```
|
||||
|
||||
|
|
@ -52,4 +52,3 @@ if X then begin
|
|||
end else
|
||||
(not X)
|
||||
```
|
||||
|
||||
|
|
|
|||
|
|
@ -8,20 +8,20 @@ _Created by Microsoft, Described by waldo_
|
|||
|
||||
## Description
|
||||
|
||||
Do not start a line with a binary operator.
|
||||
Do not start a line with a binary operator.
|
||||
|
||||
## Bad code
|
||||
|
||||
```AL
|
||||
"Quantity to Ship" :=
|
||||
Quantity
|
||||
- "Quantity Shipped"
|
||||
Quantity
|
||||
- "Quantity Shipped"
|
||||
```
|
||||
|
||||
## Good code
|
||||
|
||||
```AL
|
||||
"Quantity to Ship" :=
|
||||
Quantity -
|
||||
"Quantity Shipped"
|
||||
Quantity -
|
||||
"Quantity Shipped"
|
||||
```
|
||||
|
|
|
|||
|
|
@ -15,11 +15,11 @@ The `end else` pair should always appear on the same line.
|
|||
```al
|
||||
if OppEntry.Find('-') then
|
||||
if SalesCycleStage.Find('-') then begin
|
||||
...
|
||||
...
|
||||
end
|
||||
else
|
||||
begin
|
||||
...
|
||||
...
|
||||
end;
|
||||
```
|
||||
|
||||
|
|
@ -28,8 +28,8 @@ The `end else` pair should always appear on the same line.
|
|||
```al
|
||||
if OppEntry.Find('-') then
|
||||
if SalesCycleStage.Find('-') then begin
|
||||
...
|
||||
...
|
||||
end else begin
|
||||
...
|
||||
...
|
||||
end;
|
||||
```
|
||||
|
|
|
|||
|
|
@ -8,20 +8,20 @@ _Created by Microsoft, Described by waldo_
|
|||
|
||||
## Description
|
||||
|
||||
`if` and `else` statements should be on separate lines.
|
||||
`if` and `else` statements should be on separate lines.
|
||||
|
||||
## Bad code
|
||||
|
||||
```al
|
||||
if Atom = '\>' then HasLogicalOperator := true else begin
|
||||
...
|
||||
if Atom = '>' then HasLogicalOperator := true else begin
|
||||
...
|
||||
end;
|
||||
```
|
||||
|
||||
## Good code
|
||||
|
||||
```al
|
||||
if Atom = '\>' then
|
||||
if Atom = '>' then
|
||||
HasLogicalOperator := true
|
||||
else begin
|
||||
...
|
||||
|
|
|
|||
|
|
@ -13,31 +13,31 @@ There must be exactly one space character on each side of a binary operator such
|
|||
## Bad code
|
||||
|
||||
```al
|
||||
"Line Discount %" := "Line Discount Amount"/"Line Value"*100;
|
||||
"Line Discount %" := "Line Discount Amount"/"Line Value"*100;
|
||||
```
|
||||
|
||||
## Good code
|
||||
|
||||
```al
|
||||
"Line Discount %" := "Line Discount Amount" / "Line Value" * 100;
|
||||
"Line Discount %" := "Line Discount Amount" / "Line Value" * 100;
|
||||
```
|
||||
|
||||
## Bad code
|
||||
|
||||
```al
|
||||
StartDate := CalcDate('<+'+Format(Days+i)+'D\>',StartDate);
|
||||
StartDate := CalcDate('<+'+Format(Days+i)+'D\>',StartDate);
|
||||
```
|
||||
|
||||
## Good code
|
||||
|
||||
```al
|
||||
StartDate := CalcDate('<+' + Format(Days + i) + 'D\>', StartDate);
|
||||
StartDate := CalcDate('<+' + Format(Days + i) + 'D\>', StartDate);
|
||||
```
|
||||
|
||||
## Bad code
|
||||
|
||||
```al
|
||||
StartDate:=0D; // Initialize
|
||||
StartDate:=0D; // Initialize
|
||||
```
|
||||
|
||||
## Good code
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue