Merge pull request #154 from christianbraeunlich/feature/guideline-blank-lines

Best Practice: Avoid too many Blank Lines
This commit is contained in:
Jesper Schulz-Wedde 2022-04-06 21:16:32 +02:00 committed by GitHub
commit 32ec19fcde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -0,0 +1,159 @@
---
title: "Avoid too many blank lines"
tags: ["AL","Readability"]
categories: ["Best Practice"]
---
## Description
Avoid too many blank lines.
## Example 1
### Bad code
```al
var
UserSetup: Record "User Setup";
IsEditable: Boolean;
IsVisible: Boolean;
local procedure Initialize()
begin
IsEditable := false;
IsVisible := false;
UserSetup.Get();
end;
```
### Good code
```al
var
UserSetup: Record "User Setup";
IsEditable: Boolean;
IsVisible: Boolean;
local procedure Initialize()
begin
IsEditable := false;
IsVisible := false;
UserSetup.Get();
end;
```
## Example 2
### Bad code
```al
page 50000 "Blank Lines"
{
PageType = List;
ApplicationArea = All;
UsageCategory = Administration;
SourceTable = Customer;
layout
{
area(Content)
{
repeater(GroupName)
{
ShowCaption = false;
field(Name; Rec.Name)
{
ApplicationArea = All;
}
}
}
}
}
```
### Good code
```al
page 50000 "Blank Lines"
{
PageType = List;
ApplicationArea = All;
UsageCategory = Administration;
SourceTable = Customer;
layout
{
area(Content)
{
repeater(GroupName)
{
ShowCaption = false;
field(Name; Rec.Name)
{
ApplicationArea = All;
}
}
}
}
}
```
## Example 3
### Bad code
```al
var
GLSetup: Record "General Ledger Setup";
GLSetupRead: Boolean;
local procedure GetGLSetup()
begin
if not GLSetupRead then
GLSetup.Get();
GLSetupRead := true;
OnAfterGetGLSetup(GLSetup);
end;
[IntegrationEvent(false, false)]
local procedure OnAfterGetGLSetup(var GLSetup: Record "General Ledger Setup")
begin
end;
```
### Good code
```al
var
GLSetup: Record "General Ledger Setup";
GLSetupRead: Boolean;
local procedure GetGLSetup()
begin
if not GLSetupRead then
GLSetup.Get();
GLSetupRead := true;
OnAfterGetGLSetup(GLSetup);
end;
[IntegrationEvent(false, false)]
local procedure OnAfterGetGLSetup(var GLSetup: Record "General Ledger Setup")
begin
end;
```