From 2c4e2cc99181d7959d8faf081ac4c18fdad086d0 Mon Sep 17 00:00:00 2001 From: Christoph Krieg Date: Mon, 27 Jun 2022 19:22:33 +0200 Subject: [PATCH] Update examples --- .../if-not-find-then-exit/index.md | 40 ++++++++++++------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/content/docs/BestPractices/if-not-find-then-exit/index.md b/content/docs/BestPractices/if-not-find-then-exit/index.md index 0ca77802..ee1fe1f9 100644 --- a/content/docs/BestPractices/if-not-find-then-exit/index.md +++ b/content/docs/BestPractices/if-not-find-then-exit/index.md @@ -59,25 +59,37 @@ or ## Good code ```al - SalesHeader.Reset(); - SalesHeader.SetRange("Document Type", SalesHeader."Document Type"::Order); - SalesHeader.SetRange(Status, SalesHeader.Status::Open); - if (not SalesHeader.FindSet(false)) then - exit; + procedure DoSomethingSalesOrder() + var + SalesHeader: Record "Sales Header"; + begin + SalesHeader.Reset(); + SalesHeader.SetRange("Document Type", SalesHeader."Document Type"::Order); + SalesHeader.SetRange(Status, SalesHeader.Status::Open); + if (not SalesHeader.FindSet(false)) then + exit; - repeat + repeat + DoSomethingSalesLine(SalesHeader); + until SalesHeader.Next() = 0; + + DoSomethingElse(); + end; + + procedure DoSomethingSalesLine(var SalesHeader: Record "Sales Header") + var + SalesLine: Record "Sales Line"; + begin SalesLine.Reset(); SalesLine.SetRange("Document Type", SalesHeader."Document Type"::Order); SalesLine.SetRange("Document No.", SalesHeader."No."); - if (SalesLine.FindSet(true)) then begin - repeat - DoSomething(); - until SalesLine.Next() = 0; - end; - until SalesHeader.Next() = 0; + if (not SalesLine.FindSet(true)) then + exit; - DoSomethingElse(); -end; + repeat + DoSomething(); + until SalesLine.Next() = 0; + end; ``` or