From 0fde42cc6e14db403f043b06084f439b4ffb44a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Maro=C5=84?= Date: Wed, 15 Dec 2021 07:59:20 +0100 Subject: [PATCH] calling a procedure without parameters should have empty () --- .../BCBestPractices/Readability/unnecessary-else/index.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/BCBestPractices/Readability/unnecessary-else/index.md b/content/BCBestPractices/Readability/unnecessary-else/index.md index c3b0f301..ffad9056 100644 --- a/content/BCBestPractices/Readability/unnecessary-else/index.md +++ b/content/BCBestPractices/Readability/unnecessary-else/index.md @@ -13,7 +13,7 @@ weight = 1270 ```al procedure SomeProcedure() begin - if IsAdjmtBinCodeChanged then + if IsAdjmtBinCodeChanged() then Error(AdjmtBinCodeChangeNotAllowedErr,...) else Error(BinCodeChangeNotAllowedErr,...); @@ -24,7 +24,7 @@ weight = 1270 ```al procedure SomeProcedure() begin - if IsAdjmtBinCodeChanged then + if IsAdjmtBinCodeChanged() then Error(AdjmtBinCodeChangeNotAllowedErr,...) Error(BinCodeChangeNotAllowedErr,...); end; @@ -35,4 +35,4 @@ weight = 1270 You can find discussions on all "Best Practices" [here](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices). -If you don't find the discussion of this guideline, please feel fee to create a new one with the same title as this article. \ No newline at end of file +If you don't find the discussion of this guideline, please feel fee to create a new one with the same title as this article.