Merge pull request #89 from StefanMaron/main

Cosmetic changes to the readability pages

content/BCBestPractices/Readability/begin-end/index.md

@@ -20,7 +20,7 @@ end;
 ## Good code
 
 ```AL
-IF FindSet() then
+if FindSet() then
     repeat
     ...
     until next() = 0;
@@ -29,7 +29,7 @@ IF FindSet() then
 ## Bad code
 
 ```AL
-IF IsAssemblyOutputLine then begin
+if IsAssemblyOutputLine then begin
     TestField("Order Line No.", 0);
 end;
 ```
@@ -37,7 +37,7 @@ end;
 ## Good code
 
 ```AL
-IF IsAssemblyOutputLine then
+if IsAssemblyOutputLine then
     TestField("Order Line No.", 0);
 ```
 
@@ -45,8 +45,8 @@ IF IsAssemblyOutputLine then
 
 ```AL
 // Except for this case
-IF X then begin
+if X then begin
-    IF Y then 
+    if Y then 
         //DO SOMETHING;
 end else 
     (not X)

content/BCBestPractices/Readability/end-else-pair/index.md

@@ -17,6 +17,7 @@ The `end else` pair should always appear on the same line.
         ...
         end
         else
+        begin
         ... 
         end;
 ```
@@ -27,7 +28,7 @@ The `end else` pair should always appear on the same line.
     if OppEntry.Find('-') then
         if SalesCycleStage.Find('-') then begin
         ...
-        end else
+        end else begin
         ...
         end;
 ```

content/BCBestPractices/Readability/named-invocations/index.md

@@ -11,13 +11,13 @@ When calling an object statically use the Object Name, not the Object Id.
 ## Bad code
 
 ```al
-    Page.RunModal(525,SalesShptLine)  
+    Page.RunModal(525, SalesShptLine);
 ```
 
 ## Good code
 
 ```al
-    Page.RunModal(Page::"Posted Sales Shipment Lines",SalesShptLine)
+    Page.RunModal(Page::"Posted Sales Shipment Lines", SalesShptLine);
 ```
 
 ## [Discussions](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices?discussions_q=named+invocations+category%3A%22BC+Best+Practices%22)

content/BCBestPractices/Readability/one-statement-per-line/index.md

@@ -11,7 +11,7 @@ A line of code should not have more than one statement.
 ## Bad code
 
 ```al
-    if OppEntry.Find('-') then exit();  
+    if OppEntry.Find('-') then exit;  
 ```   
     
 
@@ -19,7 +19,7 @@ A line of code should not have more than one statement.
 
 ```al
     if OppEntry.Find('-') then   
-        exit();  
+        exit;  
 ```   
     
 ## Bad code

content/BCBestPractices/Readability/separate-if-and-else/index.md

@@ -11,7 +11,7 @@ weight = 1050
 ## Bad code
 
 ```al
-    if Atom = '\>' then HasLogicalOperator := TRUE else begin
+    if Atom = '\>' then HasLogicalOperator := true else begin
     ...
     end;
 ```

content/BCBestPractices/Readability/unnecessary-else/index.md

@@ -13,7 +13,7 @@ weight = 1270
 ```al
     procedure SomeProcedure()
     begin
-        if IsAdjmtBinCodeChanged then
+        if IsAdjmtBinCodeChanged() then
             Error(AdjmtBinCodeChangeNotAllowedErr, ...)
         else
             Error(BinCodeChangeNotAllowedErr, ...);
@@ -24,7 +24,7 @@ weight = 1270
 ```al
     procedure SomeProcedure()
     begin
-        if IsAdjmtBinCodeChanged then
+        if IsAdjmtBinCodeChanged() then
             Error(AdjmtBinCodeChangeNotAllowedErr, ...)
         Error(BinCodeChangeNotAllowedErr, ...);
     end;